Fix double-container rendering for Harmony select/dropdown menus#14085
Merged
dylanjeffers merged 1 commit intomainfrom Apr 8, 2026
Merged
Fix double-container rendering for Harmony select/dropdown menus#14085dylanjeffers merged 1 commit intomainfrom
dylanjeffers merged 1 commit intomainfrom
Conversation
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14085.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disableDefaultStylesoption to HarmonyPopupso callers can opt out of Popup’s built-in bordered/elevated shell.Menuto use that option, soMenuonly renders its intendedPapersurface.Root Cause
Popuprenders a bordered rounded surface by default.Menualso wraps children in a borderedPaper.Menutherefore showed two stacked containers.Files Changed
packages/harmony/src/components/popup/types.ts: addeddisableDefaultStylesprop toPopupProps.packages/harmony/src/components/popup/Popup.tsx: conditionally skip default popup class/shadow whendisableDefaultStylesis set.packages/harmony/src/components/internal/Menu.tsx: setdisableDefaultStylesonPopupinMenu.Validation
concurrently/tscnot found).